ci: Always run snapshotter tests on Linux#47104
Merged
thaJeztah merged 1 commit intomoby:masterfrom Jan 18, 2024
Merged
Conversation
Now that we have a green CI on linux we can enable this for all PRs. Signed-off-by: Djordje Lukic <[email protected]>
Member
vvoland
approved these changes
Jan 18, 2024
dmcgowan
approved these changes
Jan 18, 2024
thaJeztah
approved these changes
Jan 18, 2024
Member
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
it's green. it's yaml. let's merge
LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Enabled all tests with the containerd snapshotter on linux.
Now that we have a green CI on linux we can enable this for all PRs.
Windows is still behind the filter on the
containerd-integrationlabel since we have some more tests to fix- How I did it
Stared long and hard at miles and miles of yaml
- How to verify it
Look at the CI
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)