ci: Unconditionally run Linux integration with c8d store#47102
Closed
vvoland wants to merge 1 commit intomoby:masterfrom
Closed
ci: Unconditionally run Linux integration with c8d store#47102vvoland wants to merge 1 commit intomoby:masterfrom
vvoland wants to merge 1 commit intomoby:masterfrom
Conversation
Member
|
Hm... Jenkins is in a weird state; 
|
Member
|
Removed that agent; perhaps it's something with that machine; let's see if instancing a new machine fixes it 🤞 |
AkihiroSuda
approved these changes
Jan 18, 2024
Member
|
Looks like it's also running on Windows 🤔 
|
vvoland
force-pushed
the
c8d-windows-ci
branch
from
279d92f to
e1389e3
Compare
Contributor
Author
|
It failed because there were no tests actually ran and the Also looks like Hub has some issues: |
vvoland
force-pushed
the
c8d-windows-ci
branch
2 times, most recently
from
624d9e7 to
dd9a33b
Compare
rumpl
reviewed
Jan 18, 2024
| core.info(`matrix: ${JSON.stringify(matrix)}`); | ||
| core.setOutput('matrix', JSON.stringify(matrix)); | ||
| }); | ||
| run: echo 'matrix=["graphdriver", "snapshotter"]' >> "$GITHUB_OUTPUT" |
Member
There was a problem hiding this comment.
Since it's unconditional there is no need to run a script, you can:
outputs:
matrix:
- graphdriver
- snapshotter
Contributor
Author
There was a problem hiding this comment.
Thanks, fixed! I tried it initially but didn't get the job/step syntax right and then forgot about getting back to it.
Contributor
Author
There was a problem hiding this comment.
Oh, I think I actually can't:
error parsing called workflow ".github/workflows/windows-2022.yml" -> "./.github/workflows/.test-prepare.yml" : every step must define a `uses` or `run` key
0e36884 to
bbd5da3
Compare
Don't require the `containerd-integration` label on pull requests to run the integration tests on Linux with the containerd image store enabled. The label is only required to run the integration tests on Windows. Signed-off-by: Paweł Gronowski <[email protected]>
vvoland
force-pushed
the
c8d-windows-ci
branch
from
bbd5da3 to
90d39f3
Compare
crazy-max
reviewed
Jan 18, 2024
Contributor
Author
|
Closing in favor of: #47104 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't require the
containerd-integrationlabel in PRs to run the integration tests on Linux with the containerd image store enabled.The label is only required to run the integration tests on Windows.
- How to verify it
Observe CI
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)