Lazily checkpoint container health status to disk #47044
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corhere
added
status/1-design-review
kind/enhancement
corhere
changed the title
vvoland
reviewed
Jan 11, 2024
The health status and probe log of containers are not mission-criticial data which must survive a crash. It is not worth prematrely wearing out consumer-grade flash storage by overwriting and fsync()ing the container config on after every probe. Update only the live Container object and the ViewDB replica on every container health probe instead. It will eventually get checkpointed along with some other state (or config) change. Running containers will not be checkpointed on daemon shutdown when live-restore is enabled, but it does not matter: the health status and probe log will be zeroed out when the daemon starts back up. Signed-off-by: Cory Snider <[email protected]>
corhere
force-pushed
the
lazy-health-status
branch
from
c2a1a15 to
97d32bb
Compare
cpuguy83
approved these changes
Jan 16, 2024
vvoland
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Reduced the frequency of disk writes when containers are health-checked.
- How I did it
Only update the health status in-memory when a container health probe finishes. It will be checkpointed to disk the next time
container.CheckpointTo()is called, typically when the container configuration is next updated or the container lifecycle state changes. Running containers will not be checkpointed on daemon shutdown when live-restore is enabled, but it does not matter: the health status and probe log will be zeroed out when the daemon starts back up.- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)