Skip to content

update golangci-lint to v1.55.2#47016

Merged
thaJeztah merged 1 commit intomoby:masterfrom
thaJeztah:bump_golangci_lint
Jan 3, 2024
Merged

update golangci-lint to v1.55.2#47016
thaJeztah merged 1 commit intomoby:masterfrom
thaJeztah:bump_golangci_lint

Conversation

@thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Jan 3, 2024

- A picture of a cute animal (not mandatory but encouraged)

@thaJeztah thaJeztah added this to the 25.0.0 milestone Jan 3, 2024
@thaJeztah thaJeztah mentioned this pull request Jan 3, 2024
Merged
6 tasks
@thaJeztah
Copy link
Member Author

thaJeztah commented Jan 3, 2024

Ahm.. flaky test;

=== Failed
=== FAIL: amd64.integration.daemon TestLiveRestore/volume_references/local_volume_with_mount_options (2.30s)
    daemon_test.go:581: assertion failed: error is not nil: Error response from daemon: remove test-live-restore-volume-references-local: volume has active mounts
        --- FAIL: TestLiveRestore/volume_references/local_volume_with_mount_options (2.30s)

=== FAIL: amd64.integration.daemon TestLiveRestore/volume_references (16.78s)
    --- FAIL: TestLiveRestore/volume_references (16.78s)

=== FAIL: amd64.integration.daemon TestLiveRestore (0.00s)

@thaJeztah thaJeztah self-assigned this Jan 3, 2024
@thaJeztah thaJeztah merged commit 57a37ed into moby:master Jan 3, 2024
@thaJeztah thaJeztah deleted the bump_golangci_lint branch January 3, 2024 17:45
This was referenced Jan 17, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

Assignees

@thaJeztah thaJeztah

Labels

area/testing process/cherry-picked status/2-code-review

Projects

None yet

Milestone

25.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@thaJeztah @AkihiroSuda