api: Deprecate outdated fields in NetworkSettingsBase#47015
Merged
thaJeztah merged 1 commit intomoby:masterfrom Jan 3, 2024
Merged
api: Deprecate outdated fields in NetworkSettingsBase#47015thaJeztah merged 1 commit intomoby:masterfrom
thaJeztah merged 1 commit intomoby:masterfrom
Conversation
thaJeztah
added
area/api
This was referenced Jan 3, 2024
AkihiroSuda
reviewed
Jan 3, 2024
api/swagger.yaml
Outdated
| Name of the default bridge interface when dockerd's --bridge flag is set. | ||
| type: "string" | ||
| example: "docker0" | ||
| example: "" |
Member
There was a problem hiding this comment.
Is this deprecated too? Otherwise probably no need to remove this example.
Member
Author
There was a problem hiding this comment.
Ah! Good one; it looks like another commit in that PR added it back; 841932c
Let me merge those changes to the swagger file into this commit.
Member
There was a problem hiding this comment.
Oh, looks like I amended the wrong commit 🙈
The following fields are never written and are now marked as deprecated: - `HairpinMode` - `LinkLocalIPv6Address` - `LinkLocalIPv6PrefixLen` - `SecondaryIPAddress` - `SecondaryIPv6Addresses` Co-authored-by: Sebastiaan van Stijn <[email protected]> Signed-off-by: Albin Kerouanton <[email protected]>
thaJeztah
force-pushed
the
api_fields_deprecation
branch
from
e0d2750 to
ce57494
Compare
AkihiroSuda
approved these changes
Jan 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following fields are never written and are now marked as deprecated:
HairpinModeLinkLocalIPv6AddressLinkLocalIPv6PrefixLenSecondaryIPAddressSecondaryIPv6Addresses- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)