pkg/containerfs: unify CleanScopedPath implementation, and deprecate ResolveScopedPath#47006
Merged
thaJeztah merged 2 commits intomoby:masterfrom Jan 3, 2024
Merged
Conversation
Use stdlib's filepath.VolumeName to get the volume-name (if present) instead of a self-crafted implementation, and unify the implementations for Windows and Unix. Signed-off-by: Sebastiaan van Stijn <[email protected]>
If was a very shallow wrapper around symlink.FollowSymlinkInScope, so inline that code instead. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
added
status/2-code-review
impact/deprecation
kind/refactor
thaJeztah
changed the title
vvoland
approved these changes
Jan 3, 2024
neersighted
approved these changes
Jan 3, 2024
rumpl
approved these changes
Jan 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
relates to:
/pkg#32989pkg/containerfs: unify CleanScopedPath implementation
Use stdlib's filepath.VolumeName to get the volume-name (if present) instead
of a self-crafted implementation, and unify the implementations for Windows
and Unix.
pkg/containerfs: deprecate ResolveScopedPath
If was a very shallow wrapper around symlink.FollowSymlinkInScope, so inline
that code instead.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)