remove pkg/aaparser, and inline remaining functionality in profiles/apparmor#47005
Merged
AkihiroSuda merged 2 commits intomoby:masterfrom Jan 2, 2024
Merged
remove pkg/aaparser, and inline remaining functionality in profiles/apparmor#47005AkihiroSuda merged 2 commits intomoby:masterfrom
AkihiroSuda merged 2 commits intomoby:masterfrom
Conversation
Commit e3e7156 (included in v24.0.0 through bfffb09) deprecated GetVersion, as it was no longer used. This patch removes the deprecated utility, and inlines the remaining code into the LoadProfile function. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
added
area/security/apparmor
status/2-code-review
impact/deprecation
kind/refactor
Member
Author
|
Hmmm... some hiccup with Docker Hub? Or maybe it's the mirroring that went whoops? |
This package provided utilities to obtain the apparmor_parser version, as well as loading a profile. Commit e3e7156 (included in v24.0.0 through bfffb09) deprecated GetVersion, as it was no longer used, which made LoadProfile the only utility remaining in this package. LoadProfile appears to have no external consumers, and the only use in our code is "profiles/apparmor". This patch moves the remaining code (LoadProfile) to profiles/apparmor as a non-exported function, and deletes the package. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
remove_pkg_aaparser
branch
from
4f59213 to
6fae583
Compare
Member
Author
|
Hm... I think Docker Hub may not be entirely happy; |
neersighted
approved these changes
Jan 2, 2024
AkihiroSuda
approved these changes
Jan 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
relates to
/pkg#32989pkg/aaparser: remove deprecated GetVersion utility
Commit e3e7156 (included in v24.0.0 through
bfffb09) deprecated GetVersion, as it was no
longer used.
This patch removes the deprecated utility, and inlines the remaining code into
the LoadProfile function.
pkg/aaparser: remove, and integrate into profiles/apparmor
This package provided utilities to obtain the apparmor_parser version, as well
as loading a profile.
Commit e3e7156 (included in v24.0.0 through
bfffb09) deprecated GetVersion, as it was no
longer used, which made LoadProfile the only utility remaining in this package.
LoadProfile appears to have no external consumers, and the only use in our code
is "profiles/apparmor"; https://grep.app/search?q=github.com/docker/docker/pkg/aaparser
This patch moves the remaining code (LoadProfile) to profiles/apparmor as a
non-exported function, and deletes the package.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)