Skip to content

Add proper support for relative WORKDIR instructions#4691

Merged
crosbymichael merged 3 commits intomoby:masterfrom
tianon:relative-workdir
Mar 19, 2014
Merged

Add proper support for relative WORKDIR instructions#4691
crosbymichael merged 3 commits intomoby:masterfrom
tianon:relative-workdir

Conversation

@tianon
Copy link
Copy Markdown
Member

@tianon tianon commented Mar 15, 2014

Fixes #3937

Docker-DCO-1.1-Signed-off-by: Andrew Page <[email protected]> (github: tianon)
@SvenDowideit
Copy link
Copy Markdown
Contributor

can you please mention it in the cli docs too - otherwise people will wonder, and some won't even try it

@tianon
Copy link
Copy Markdown
Member Author

tianon commented Mar 17, 2014

And they would be better off without! Humph! :)

Ok ok, I'll see about adding a blurb to the docs. :P

@crosbymichael
Copy link
Copy Markdown
Contributor

LGTM

for the code

@vieux
Copy link
Copy Markdown
Contributor

vieux commented Mar 17, 2014

LGTM

@vieux
Copy link
Copy Markdown
Contributor

vieux commented Mar 18, 2014

ping @SvenDowideit

@tianon
Copy link
Copy Markdown
Member Author

tianon commented Mar 18, 2014

Ok, I improved the test slightly to cover our edge case better, and added some documentation to explain that this works and how it works. As always, let me know what needs to be improved. :)

@tianon
Copy link
Copy Markdown
Member Author

tianon commented Mar 18, 2014

Doh, my test is failing for me now, give me a minute to figure out why.

tianon added 2 commits March 17, 2014 19:42
Docker-DCO-1.1-Signed-off-by: Andrew Page <[email protected]> (github: tianon)
Docker-DCO-1.1-Signed-off-by: Andrew Page <[email protected]> (github: tianon)
@tianon
Copy link
Copy Markdown
Member Author

tianon commented Mar 18, 2014

Ok, the test should be fixed now. My machine is taking forever to download "docker-test-image" this evening, so I haven't verified it for sure, but will verify as soon as it finishes.

@tianon
Copy link
Copy Markdown
Member Author

tianon commented Mar 18, 2014

Ok, test looks good now. 👍

@SvenDowideit
Copy link
Copy Markdown
Contributor

Docs LGTM

(I wonder what happens now if someone does ADD file ./ - yes, don't add that to this PR)

@tianon
Copy link
Copy Markdown
Member Author

tianon commented Mar 18, 2014

I wondered about relative ADD myself, but agree that it's a separate issue. :)

crosbymichael added a commit that referenced this pull request Mar 19, 2014
Add proper support for relative WORKDIR instructions
@crosbymichael crosbymichael merged commit 47470d2 into moby:master Mar 19, 2014
@tianon tianon deleted the relative-workdir branch March 19, 2014 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

WORKDIR relativepath - succeeds, but uses it as though it has a leading /

4 participants