Fix case where health start interval is 0 uses default#46764
Merged
thaJeztah merged 1 commit intomoby:masterfrom Nov 3, 2023
Merged
Fix case where health start interval is 0 uses default#46764thaJeztah merged 1 commit intomoby:masterfrom
thaJeztah merged 1 commit intomoby:masterfrom
Conversation
When the start interval is 0 we should treat that as unset. This is especially important for older API versions where we reset the value to 0. Instead of using the default probe value we should be using the configured `interval` value (which may be a default as well) which gives us back the old behavior before support for start interval was added. Signed-off-by: Brian Goff <[email protected]>
corhere
approved these changes
Nov 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the start interval is 0 we should treat that as unset. This is especially important for older API versions where we reset the value to 0.
Instead of using the default probe value we should be using the configured
intervalvalue (which may be a default as well) which gives us back the old behavior before support for start interval was added.