c8d/resolver: Don't reject auth with empty ServerAddress#46745
Closed
vvoland wants to merge 1 commit intomoby:masterfrom
Closed
c8d/resolver: Don't reject auth with empty ServerAddress#46745vvoland wants to merge 1 commit intomoby:masterfrom
vvoland wants to merge 1 commit intomoby:masterfrom
Conversation
The graphdriver's implementation doesn't check if the ServerAddress matches. To make the API behavior consistent, treat empty ServerAddress as a wildcard. Signed-off-by: Paweł Gronowski <[email protected]>
vvoland
added
area/distribution
rumpl
approved these changes
Oct 30, 2023
thaJeztah
requested changes
Oct 31, 2023
Member
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
(leaving a quick "request changes", as there's some things we're discussing, and I'd like to check)
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The graphdriver's implementation doesn't check if the ServerAddress matches. To make the API behavior consistent, treat empty ServerAddress as a wildcard.
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)