Skip to content

vendor.mod: bump go line to 1.20#46562

Merged
thaJeztah merged 1 commit intomoby:masterfrom
neersighted:go_mod_bump
Sep 28, 2023
Merged

vendor.mod: bump go line to 1.20#46562
thaJeztah merged 1 commit intomoby:masterfrom
neersighted:go_mod_bump

Conversation

@neersighted
Copy link
Member

@neersighted neersighted commented Sep 28, 2023

@thaJeztah
Copy link
Member

Looks like you included the other commits as well; can you make it with only the go.mod changes?

@thaJeztah
Copy link
Member

(given that we're already on go1.20, that should still work I think?)

Signed-off-by: Bjorn Neergaard <[email protected]>
@neersighted
Copy link
Member Author

Ah, I intentionally stacked this on top of your branch, but you make a fair point that we can do this independent of your changes.

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

wondering if we still need the -compat option, or if we can remove that one (but that's perfectly fine for a separate PR);

"${SCRIPTDIR}"/with-go-mod.sh go mod tidy -modfile vendor.mod -compat 1.18

@thaJeztah
Copy link
Member

Ah, I intentionally stacked this on top of your branch, but you make a fair point that we can do this independent of your changes.

Yes, and I think we should merge this PR before mine to have the changes in the desired order 😄

@thaJeztah thaJeztah merged commit 1239c96 into moby:master Sep 28, 2023
@neersighted neersighted deleted the go_mod_bump branch September 29, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants