[24.0 backport] rename uses of "max", "min", which are now builtins in go1.21#46559
Merged
AkihiroSuda merged 8 commits intomoby:24.0from Sep 28, 2023
Merged
[24.0 backport] rename uses of "max", "min", which are now builtins in go1.21#46559AkihiroSuda merged 8 commits intomoby:24.0from
AkihiroSuda merged 8 commits intomoby:24.0from
Conversation
Signed-off-by: Sebastiaan van Stijn <[email protected]> (cherry picked from commit cb394a6) Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]> (cherry picked from commit 318b3d4) Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]> (cherry picked from commit a386799) Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]> (cherry picked from commit 55192de) Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]> (cherry picked from commit 6c036f2) Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]> (cherry picked from commit df2f25a) Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]> (cherry picked from commit 79495c5) Signed-off-by: Sebastiaan van Stijn <[email protected]>
… builtin Signed-off-by: Sebastiaan van Stijn <[email protected]> (cherry picked from commit fa13b07) Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
added
status/2-code-review
kind/refactor
neersighted
approved these changes
Sep 28, 2023
AkihiroSuda
approved these changes
Sep 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- A picture of a cute animal (not mandatory but encouraged)
- A picture of a cute animal (not mandatory but encouraged)