c8d: Skip TestRemoveImageGarbageCollector#46507
Merged
thaJeztah merged 2 commits intomoby:masterfrom Sep 18, 2023
Merged
Conversation
This test checks how the layer store works, so we don't need it when we use containerd as image store Signed-off-by: Djordje Lukic <[email protected]>
rumpl
added
status/2-code-review
kind/bugfix
neersighted
approved these changes
Sep 18, 2023
vvoland
approved these changes
Sep 18, 2023
thaJeztah
reviewed
Sep 18, 2023
| @@ -2540,14 +2540,14 @@ func (s *DockerDaemonSuite) TestExecWithUserAfterLiveRestore(c *testing.T) { | |||
|
|
|||
| func (s *DockerDaemonSuite) TestRemoveContainerAfterLiveRestore(c *testing.T) { | |||
| testRequires(c, DaemonIsLinux, overlayFSSupported, testEnv.IsLocalDaemon) | |||
Member
There was a problem hiding this comment.
Is the overlayFSSupported still need if we remove the --storage-driver option?
rumpl
force-pushed
the
c8d-fix-tests
branch
from
4b46dfd to
7e0eb8a
Compare
There is no need to pass the storage driver to the daemon the test starts Signed-off-by: Djordje Lukic <[email protected]>
rumpl
force-pushed
the
c8d-fix-tests
branch
from
7e0eb8a to
6c563cd
Compare
Member
|
Failure on Ubuntu is this one (I think I've seen it fail a few times; looks like it's flaky, perhaps we need a tracking ticket if we don't have one yet); |
Member
Author
|
Opened an issue #46508 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
TestRemoveImageGarbageCollector, it tests the layer storeTestRemoveContainerAfterLiveRestore, there is no need to pass the storage driver when starting the daemon- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)
This test checks how the layer store works, so we don't need it when we
use containerd as image store
Signed-off-by: Djordje Lukic [email protected]