distribution: filterManifests split complicated condition#46415
Merged
thaJeztah merged 1 commit intomoby:masterfrom Sep 7, 2023
Merged
distribution: filterManifests split complicated condition#46415thaJeztah merged 1 commit intomoby:masterfrom
thaJeztah merged 1 commit intomoby:masterfrom
Conversation
Break up the complicated "if" condition into multiple checks. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
added
area/distribution
1 task
rumpl
reviewed
Sep 7, 2023
| // TODO(thaJeztah): should we also take the user-provided platform into account (if any)? | ||
| if strings.EqualFold("windows", manifestDescriptor.Platform.OS) { | ||
| if err := checkImageCompatibility("windows", manifestDescriptor.Platform.OSVersion); err != nil { | ||
| skip() |
Member
There was a problem hiding this comment.
In the old code we wouldn't have this debug log here but I guess it's fine
Member
Author
There was a problem hiding this comment.
Ah, yes, I probably should've mentioned that. I was writing the code, and thought having a log for this case would be useful as well (with all the windows-matching already being quite "hairy").
rumpl
approved these changes
Sep 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Break up the complicated "if" condition into multiple checks.
- A picture of a cute animal (not mandatory but encouraged)