client: TestImageTagInvalidSourceImageName remove invalid test-case#46378
Merged
thaJeztah merged 1 commit intomoby:masterfrom Aug 31, 2023
Merged
client: TestImageTagInvalidSourceImageName remove invalid test-case#46378thaJeztah merged 1 commit intomoby:masterfrom
thaJeztah merged 1 commit intomoby:masterfrom
Conversation
The test considered `Foo/bar` to be an invalid name, with the assumption
that it was `[docker.io]/Foo/bar`. However, this was incorrect, and the
test passed because the reference parsing had a bug; if the first element
(`Foo`) is not lowercase (so not a valid namespace / "path element"), then
it *should* be considered a domain (as uppercase domain names are valid).
The reference parser did not account for this, and running the test with
a version of the parser with a fix caused the test to fail:
=== Failed
=== FAIL: client TestImageTagInvalidSourceImageName/invalidRepo/FOO/bar (0.00s)
image_tag_test.go:54: assertion failed: expected error to contain "not a valid repository/tag", got "Error response from daemon: client should not have made an API call"
Error response from daemon: client should not have made an API call
=== FAIL: client TestImageTagInvalidSourceImageName (0.00s)
This patch removes the faulty test-case.
Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
added
status/2-code-review
area/testing
process/cherry-pick
kind/bugfix
vvoland
approved these changes
Aug 31, 2023
This was referenced Aug 31, 2023
thaJeztah
added
process/cherry-pick/23.0
process/cherry-pick/24.0
and removed
process/cherry-pick
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test considered
Foo/barto be an invalid name, with the assumption that it was[docker.io]/Foo/bar. However, this was incorrect, and the test passed because the reference parsing had a bug; if the first element (Foo) is not lowercase (so not a valid namespace / "path element"), then it should be considered a domain (as uppercase domain names are valid).The reference parser did not account for this, and running the test with a version of the parser with a fix caused the test to fail:
This patch removes the faulty test-case.
- A picture of a cute animal (not mandatory but encouraged)