image/specs: add missing OnBuild (v1.0), ArgsEscaped (v1.1), and Shell (v1.2) fields#46371
Merged
thaJeztah merged 3 commits intomoby:masterfrom Aug 30, 2023
Merged
image/specs: add missing OnBuild (v1.0), ArgsEscaped (v1.1), and Shell (v1.2) fields#46371thaJeztah merged 3 commits intomoby:masterfrom
thaJeztah merged 3 commits intomoby:masterfrom
Conversation
This field was added in commit 9f994c9, which was merged before the image-spec v1.0.0 was released (which happened in commit 7991062). This patch backfills the specifications to describe the property. Signed-off-by: Sebastiaan van Stijn <[email protected]>
This field was added in 9db5db1, which was part of v1.10.0-rc1 and later, which used image spec v1.1.0. It's worth noting that documentation for the v1.1.0 image spec was not yet available until commit 4fa0ecc, which was included in v1.12.0-rc1 and up. The `ArgsEscaped` field was also adopted by the OCI image spec since [v1.1.0-rc3][1], but considered deprecated, and not recommended to be used. This patch amends the v1.1 and v1.2 specifications to describe the field. [1]: opencontainers/image-spec@59780aa Signed-off-by: Sebastiaan van Stijn <[email protected]>
vvoland
approved these changes
Aug 30, 2023
Member
Author
|
Oh! Let me double-check if the fields are in the right spot, and that they're in the image config, not the container config |
Member
Author
|
Oh, hm.. ContainerConfig is not part of the spec, so I guess we’re good |
rumpl
approved these changes
Aug 30, 2023
This field was added in b18ae8c, which was part of v1.12.0-rc1 and later, which used image spec v1.2.0. This patch amends the v1.2 spec to include the missing field. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
changed the title
Member
Author
|
Pushed a commit to also document |
vvoland
approved these changes
Aug 30, 2023
rumpl
approved these changes
Aug 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
relates to:
image/spec: add missing "OnBuild" field
This field was added in commit 9f994c9,
which was merged before the image-spec v1.0.0 was released (which happened
in commit 7991062).
This patch back-fills the specifications to describe the property.
image/spec: add missing "ArgsEscaped" field (v1.1, v1.2)
This field was added in 9db5db1, which
was part of v1.10.0-rc1 and later, which used image spec v1.1.0.
It's worth noting that documentation for the v1.1.0 image spec was not
yet available until commit 4fa0ecc,
which was included in v1.12.0-rc1 and up. The
ArgsEscapedfield wasalso adopted by the OCI image spec since v1.1.0-rc3, but considered
deprecated, and not recommended to be used.
This patch amends the v1.1 and v1.2 specifications to describe the field.
image/spec: add missing "Shell" field (v1.2)
This field was added in b18ae8c, which
was part of v1.12.0-rc1 and later, which used image spec v1.2.0.
This patch amends the v1.2 spec to include the missing field.
- A picture of a cute animal (not mandatory but encouraged)