Merged
Conversation
rumpl
reviewed
Aug 29, 2023
vvoland
force-pushed
the
image-spec-specs-go
branch
from
dcff973 to
28820c5
Compare
rumpl
approved these changes
Aug 29, 2023
vvoland
force-pushed
the
image-spec-specs-go
branch
from
28820c5 to
ae52ab5
Compare
thaJeztah
reviewed
Aug 30, 2023
| @@ -0,0 +1,54 @@ | |||
| package v1 | |||
Member
There was a problem hiding this comment.
LOL, I hate the v1 package name, but it's consistent with the OCI-spec's structure, so 🤷♂️
thaJeztah
reviewed
Aug 30, 2023
vvoland
force-pushed
the
image-spec-specs-go
branch
from
ae52ab5 to
db849c1
Compare
This was referenced Aug 30, 2023
vvoland
force-pushed
the
image-spec-specs-go
branch
from
db849c1 to
a4087f7
Compare
Contributor
Author
|
Rebased on master after #46381 was merged. @thaJeztah @rumpl still LGTY? |
Add Go structs describing the image spec which extend the OCI types. Signed-off-by: Paweł Gronowski <[email protected]>
vvoland
force-pushed
the
image-spec-specs-go
branch
from
a4087f7 to
366a5f1
Compare
thaJeztah
approved these changes
Aug 31, 2023
Member
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
LGTM
it looks like the OCI has some tests to verify backward compatibility; when we're preparing to move the spec out, we should probably consider having something similar as that; https://github.com/opencontainers/image-spec/blob/3131ecd26bfc92a41f3fbf0d13d4d9063f0f36c2/schema/backwards_compatibility_test.go#L27-L45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an initial effort to add a canonical implementation of the Docker Image spec (
application/vnd.docker.container.image.v1+json).The intent was to share as much of the implementation with the OCI image spec and allow for easy conversion between OCI image and Docker OCI image.
- What I did
Add Go structs describing the image spec which extend the OCI types.
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)