Remove uses of deprecated "Status", "ID", and "From" fields for events#46336
Merged
thaJeztah merged 7 commits intomoby:masterfrom Aug 28, 2023
Merged
Remove uses of deprecated "Status", "ID", and "From" fields for events#46336thaJeztah merged 7 commits intomoby:masterfrom
thaJeztah merged 7 commits intomoby:masterfrom
Conversation
thaJeztah
added
status/2-code-review
impact/deprecation
kind/refactor
thaJeztah
changed the title
thaJeztah
force-pushed
the
events_deprecated_fields
branch
2 times, most recently
from
e299f6a to
20244fb
Compare
4 tasks
- clean up "//import" comment, as test-files cannot be imported, and only one "//import" comment is needed per package. - remove some intermediate variables - rewrite assertions to use gotest.tools - use assert.Check()) (non-fatal) where possible Signed-off-by: Sebastiaan van Stijn <[email protected]>
Some tests were testing the deprecated fields, instead of their non-deprecated alternatives. This patch adds a utility to verify that they match, and rewrites the tests to check the non-deprecated fields instead. Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
… fields Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
events_deprecated_fields
branch
from
20244fb to
333e04e
Compare
vvoland
approved these changes
Aug 28, 2023
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These fields were deprecated in Docker 1.10 through 72f1881 (#18888), but were still used in various places and in tests.
daemon/events: rewrite test-assertions with gotest.tools
one "//import" comment is needed per package.
daemon/events: verify non-deprecated fields
Some tests were testing the deprecated fields, instead of their non-deprecated
alternatives.
This patch adds a utility to verify that they match, and rewrites the tests
to check the non-deprecated fields instead.
client: TestEvents: don't depend on deprecated fields
integration/container: TestPause: don't depend on deprecated fields
daemon: TestHealthStates: don't depend on deprecated fields
integration-cli: TestEventsFormat: rewrite test to not use deprecated fields
- A picture of a cute animal (not mandatory but encouraged)