daemon: Improve NetworkingConfig & EndpointSettings validation#46183
Merged
thaJeztah merged 9 commits intomoby:masterfrom Sep 18, 2023
Merged
daemon: Improve NetworkingConfig & EndpointSettings validation#46183thaJeztah merged 9 commits intomoby:masterfrom
thaJeztah merged 9 commits intomoby:masterfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on:
- What I did
So far, only a subset of
NetworkingConfigwas validated when callingContainerCreate. Other parameters would be validated when the container was started. And the same goes forEndpointSettingsonNetworkConnect.Also, the validation code was early exiting as soon as it caught an error. It now tries to validate as much as it can, and returns all the errors.
- How to verify it
Testing with the CLI won't work because it has its own client-side layer of validation (although incomplete). Some Go code has to be written to test all validation cases.
- Description for the changelog
NetworkConnectandContainerCreatehave improved data validation, and now return all validation errors at once.