client: Client.buildRequest: use http.NewRequestWithContext#46171
Merged
thaJeztah merged 3 commits intomoby:masterfrom Aug 10, 2023
Merged
client: Client.buildRequest: use http.NewRequestWithContext#46171thaJeztah merged 3 commits intomoby:masterfrom
thaJeztah merged 3 commits intomoby:masterfrom
Conversation
thaJeztah
added
status/2-code-review
kind/refactor
vvoland
approved these changes
Aug 8, 2023
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Re-use the request, and change the method to GET instead of building a new request "from scratch". Signed-off-by: Sebastiaan van Stijn <[email protected]>
Attach the context to the request while we're creating it, instead of creating the context first, and adding the context later. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
client_context
branch
from
9343549 to
4cc796a
Compare
cpuguy83
approved these changes
Aug 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
client: Client.checkResponseErr: change errorMessage to an error
client: Client.Ping: re-use request when falling back to GET
Re-use the request, and change the method to GET instead of building
a new request "from scratch".
client: Client.buildRequest: use http.NewRequestWithContext
Attach the context to the request while we're creating it, instead of
creating the context first, and adding the context later.
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)