[do not merge] rebase of "Add otel tracing" on top of "Fix TestDaemonProxy integration tests"#46126
Closed
thaJeztah wants to merge 3 commits intomoby:masterfrom
Closed
[do not merge] rebase of "Add otel tracing" on top of "Fix TestDaemonProxy integration tests"#46126thaJeztah wants to merge 3 commits intomoby:masterfrom
thaJeztah wants to merge 3 commits intomoby:masterfrom
Conversation
Merged
thaJeztah
commented
Jul 31, 2023
thaJeztah
commented
Jul 31, 2023
thaJeztah
force-pushed
the
otel_rebase
branch
2 times, most recently
from
2769fee to
9635e2f
Compare
This uses otel standard environment variables to configure tracing in the daemon. It also adds support for propagating trace contexts in the client and reading those from the API server. See https://opentelemetry.io/docs/specs/otel/configuration/sdk-environment-variables/ for details on otel environment variables. Signed-off-by: Brian Goff <[email protected]>
Integration tests will now configure clients to propagate traces as well as create spans for all tests. Some extra changes were needed (or desired for trace propagation) in the test helpers to pass through tracing spans via context. Signed-off-by: Brian Goff <[email protected]>
This wires up the integration tests to export spans to a jager instance. After tests are finished it exports the data out of jaeger and uploads as an artifact to the action run. Signed-off-by: Brian Goff <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To see how "bad" it is. I kept the
TestDaemonProxy: check proxy settings earlycommit separate, but moved it after the "Wire up tests to support otel tracing" commit, as it should be squashed into that one.- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)