daemon: remove --oom-score-adjust flag#46113
Merged
thaJeztah merged 1 commit intomoby:masterfrom Jan 20, 2024
Merged
Conversation
akerouanton
commented
Jul 29, 2023
| flags.StringVar(&conf.CgroupParent, "cgroup-parent", "", "Set parent cgroup for all containers") | ||
| flags.StringVar(&conf.RemappedRoot, "userns-remap", "", "User/Group setting for user namespaces") | ||
| flags.BoolVar(&conf.LiveRestoreEnabled, "live-restore", false, "Enable live restore of docker when containers are still running") | ||
| // TODO(thaJeztah): Used to produce a deprecation error; remove the flag and the OOMScoreAdjust field for the next release after v25.0.0. |
Member
Author
There was a problem hiding this comment.
This comment suggests it should be dropped in v26.0, whereas the docs suggests it should be dropped in v25.0 (cf. https://docs.docker.com/engine/deprecated/#oom-score-adjust-for-the-daemon).
Member
There was a problem hiding this comment.
Ah, yes, so;
- it was deprecated (warning only) in v24.0.0 daemon: deprecate --oom-score-adjust for the daemon #45315
- And changed to an error for v25.0.0 remove deprecated types, fields, and functions #45484
So this PR should wait until after v25.0.0; the idea here is to produce a "more meaningful" error than
Status: unknown flag: --oom-score-adjust
See 'dockerd --help'., Code: 125So I guess we should put this PR on the "future" milestone, and keep it in draft until we started a "25.0" release branch
thaJeztah
requested changes
Jul 29, 2023
Member
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
See my comment above (changes look good, but need to wait for a bit 😄)
Member
Author
|
I'm converting this PR into a draft until we have a 25.0 branch. |
This flag was marked deprecated in commit 5a922dc (released in v24.0) and to be removed in the next release. Signed-off-by: Albin Kerouanton <[email protected]>
thaJeztah
force-pushed
the
remove-deprecated-oom-score-adjust
branch
from
f7d5d36 to
f07c45e
Compare
This was referenced Jan 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
This flag was marked as deprecated in commit 5a922dc (released in v24.0) and to be removed in the next release.
- Description for the changelog
--oom-score-adjusthas been deprecated in v24.0 and is now removed.