update to go1.21.1, default to GOTOOLCHAIN=local#46069
Merged
thaJeztah merged 2 commits intomoby:masterfrom Sep 28, 2023
Merged
update to go1.21.1, default to GOTOOLCHAIN=local#46069thaJeztah merged 2 commits intomoby:masterfrom
thaJeztah merged 2 commits intomoby:masterfrom
Conversation
neersighted
changed the title
neersighted
force-pushed
the
update_to_go1.21
branch
3 times, most recently
from
79cd2f9 to
a93a895
Compare
thaJeztah
force-pushed
the
update_to_go1.21
branch
4 times, most recently
from
07aa3cf to
7555ca6
Compare
This was referenced Aug 25, 2023
Merged
Merged
thaJeztah
force-pushed
the
update_to_go1.21
branch
from
7555ca6 to
e99d6a7
Compare
This was referenced Aug 25, 2023
thaJeztah
force-pushed
the
update_to_go1.21
branch
2 times, most recently
from
dc21b1f to
d0ad173
Compare
Contributor
|
For reference, this should also resolve the Docker occurrence of microsoft/Windows-Containers#213. microsoft/hcsshim#696 (comment) has records of me testing the Go-side fix with Docker. I'm not sure off-hand whether enabling the containerd backend with or without containerd storage enabled would revivify that failure case, as I'm a long time away from remembering how the Docker graph-driver integrates with containerd. Basically, whoever calls |
thaJeztah
force-pushed
the
update_to_go1.21
branch
from
d0ad173 to
ddcd3e2
Compare
thaJeztah
force-pushed
the
update_to_go1.21
branch
from
ddcd3e2 to
ac2ee8f
Compare
thaJeztah
changed the title
Related discussion in docker-library/golang#472 Signed-off-by: Sebastiaan van Stijn <[email protected]>
This required changes to the download-URL, as downloads are now provided
using the full version (including the `.0` patch version);
curl -sI https://go.dev/dl/go1.21.windows-amd64.zip | grep 'location'
location: https://dl.google.com/go/go1.21.windows-amd64.zip
curl -sI https://dl.google.com/go/go1.21.windows-amd64.zip
HTTP/2 404
# ...
curl -sI https://dl.google.com/go/go1.21.0.windows-amd64.zip
HTTP/2 200
# ...
Unfortunately this also means that the GO_VERSION can no longer be set to
versions lower than 1.21.0 (without additional changes), because older
versions do NOT provide the `.0` version, and Go 1.21.0 and up, no longer
provides URLs _without_ the `.0` version.
Co-authored-by: Bjorn Neergaard <[email protected]>
Signed-off-by: Bjorn Neergaard <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
update_to_go1.21
branch
from
ac2ee8f to
e465ebf
Compare
neersighted
approved these changes
Sep 28, 2023
rumpl
approved these changes
Sep 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related / depends on:
Updating to go 1.21 to see if things all work as expected
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)