Add CDISpecDirs to Info output#46004
Merged
thaJeztah merged 3 commits intomoby:masterfrom Aug 7, 2023
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the following changes:
"cdi-spec-dirs"in the daemon config or specifying--cdi-spec-dir=""will disable CDI injection even if experimental mode is enabled.cdi-spec-dirsis added to the system info output. Note that an empty slice is explicitly output. This is a follow-up to the changes adding CDI support as per Add support for CDI devices under Linux #45134 (comment).- What I did
Added the configured
cdi-spec-dirsto the system info output.- How I did it
loadDaemonCliConfigto handle the case where the option is not set to an empty slice.system.Infostruct with aCDISpecDirsfield that is filled from the config option whendaemon.SystemInfois called.- How to verify it
The change includes unit tests to ensure that the applied setting is returned.
- Description for the changelog
cdi-spec-dirsis empty or set to a single empty string using the command line arguments.CDISpecDirsto system info output.- A picture of a cute animal (not mandatory but encouraged)