Add health start interval support to swarm mode#45965
Merged
thaJeztah merged 2 commits intomoby:masterfrom Jul 14, 2023
Merged
Conversation
12 tasks
12 tasks
corhere
approved these changes
Jul 13, 2023
Member
|
quick blurb; need to check if the API is affected and swagger + version-history needs an update |
cpuguy83
force-pushed
the
swarm_health_start_interval
branch
from
fcd8d0f to
bdd30a4
Compare
corhere
approved these changes
Jul 13, 2023
Member
Author
|
@thaJeztah Yes API is affected but it was already updated in the original PR (b/c swarm is using the same struct in the swagger and in the actual API implementation). |
neersighted
approved these changes
Jul 14, 2023
Member
neersighted
left a comment
neersighted
left a comment
There was a problem hiding this comment.
Could you add the SwarmKit version to the commit message? e.g. make the first line vendor: github.com/moby/swarmkit/v2 v2.0.0-20230713153928-bc71908479e5?
Otherwise, LGTM
This brings in changes needed to support health start intervals in swarm. Signed-off-by: Brian Goff <[email protected]>
Adds conversions for health start interval to/from grpc for swarmkit. Signed-off-by: Brian Goff <[email protected]>
cpuguy83
force-pushed
the
swarm_health_start_interval
branch
from
bdd30a4 to
f93cfb2
Compare
Member
Author
|
Updated the commit message. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #45897