ci(bin-image): fix meta step#45932
Merged
neersighted merged 2 commits intomoby:masterfrom Jul 12, 2023
Merged
Conversation
Signed-off-by: CrazyMax <[email protected]>
We can't upload the same file in a matrix so generate metadata in prepare job instead. Also fixes wrong bake meta file in merge job. Signed-off-by: CrazyMax <[email protected]>
neersighted
approved these changes
Jul 11, 2023
Member
Author
|
BuildKit workflow is not healthy since yesterday on PRs but also master. I see many timeouts and does not look related to any changes in the code base: https://github.com/moby/moby/actions/runs/5524958864/jobs/10085371569?pr=45932#step:10:2889
@neersighted Did something changed in repo settings related to actions/runners? |
Member
|
Merging through failures as this PR is not related to any of them, and they are caused by #22000. |
This was referenced Jul 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow-up #45930
- What I did
Got another issue with previous fix where digest from metadata build result output was empty because of a typo on target name: https://github.com/moby/moby/actions/runs/5524595417/jobs/10077121927#step:8:3
Also needed to fix the meta step and bake meta file in merge job. We can't upload the same file in a matrix so we have to generate metadata in prepare job instead.
- How I did it
- How to verify it
To be sure it works I triggered the workflow on my fork: https://github.com/crazy-max/moby/actions/runs/5524785463
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)