Skip to content

bin-image bake target#45519

Merged
thaJeztah merged 2 commits intomoby:masterfrom
crazy-max:bin-image
May 11, 2023
Merged

bin-image bake target#45519
thaJeztah merged 2 commits intomoby:masterfrom
crazy-max:bin-image

Conversation

@crazy-max
Copy link
Copy Markdown
Member

@crazy-max crazy-max commented May 11, 2023

follow-up #44740 (review)

- What I did

Add bin-image and bin-image-cross bake targets to build and load a non-runnable image containing bundles.

Also adds a workflow that will just build this target for sanity check. In follow-up we could then update the workflow to login to the registry and push this image.

- How I did it

- How to verify it

# load moby-bin:local image to docker
$ docker buildx bake bin-image
# push multi-platform image to craymax/moby-bin:latest
$ docker buildx bake bin-image-cross --set *.tags=crazymax/moby-bin:latest --push

https://explore.ggcr.dev/?image=crazymax/moby-bin:latest

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

crazy-max added 2 commits May 11, 2023 15:52
@crazy-max
bin-image bake target
ae1ca67 
Allows to build a non-runnable image that contains bundles.

Signed-off-by: CrazyMax <[email protected]>
@crazy-max
ci: bin-image workflow
135d8f0 
This workflow will just build the bin-image bake target.

Signed-off-by: CrazyMax <[email protected]>
@thaJeztah
Copy link
Copy Markdown
Member

thaJeztah commented May 11, 2023

GHA on this one only does the building, and no pushing, correct?

@thaJeztah thaJeztah added this to the 25.0.0 milestone May 11, 2023
@crazy-max
Copy link
Copy Markdown
Member Author

crazy-max commented May 11, 2023

GHA on this one only does the building, and no pushing, correct?

Yes:

...will just build this target for sanity check.

thaJeztah
thaJeztah approved these changes May 11, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crazy-max crazy-max mentioned this pull request May 11, 2023
Merged
@thaJeztah
Copy link
Copy Markdown
Member

thaJeztah commented May 11, 2023

I think one of the windows checks got stuck (and will probably time-out).

Given that this change should not affect any Windows code, I'll bring this one in

@thaJeztah thaJeztah merged commit 9983d89 into moby:master May 11, 2023
@crazy-max crazy-max deleted the bin-image branch May 11, 2023 16:34
@crazy-max crazy-max mentioned this pull request May 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rumpl rumpl rumpl approved these changes

@thaJeztah thaJeztah thaJeztah approved these changes

@neersighted neersighted Awaiting requested review from neersighted

Assignees

No one assigned

Labels

area/testing process/cherry-picked status/2-code-review

Projects

None yet

Milestone

25.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@crazy-max @thaJeztah @rumpl