pkg/aaparser: deprecate GetVersion, as it's no longer used#45496
Merged
thaJeztah merged 1 commit intomoby:masterfrom May 9, 2023
Merged
pkg/aaparser: deprecate GetVersion, as it's no longer used#45496thaJeztah merged 1 commit intomoby:masterfrom
thaJeztah merged 1 commit intomoby:masterfrom
Conversation
Member
Author
|
GolangCI lint is failing because the other PRs weren't merged yet (I'll rebase once they are) |
neersighted
approved these changes
May 8, 2023
vvoland
approved these changes
May 9, 2023
rumpl
approved these changes
May 9, 2023
Our templates no longer contain version-specific rules, so this function is no longer used. This patch deprecates it. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
pkg_aaparser_deprecate_version
branch
from
3e787f8 to
e3e7156
Compare
Member
Author
|
Rebased to make CI pass now that the other PRs were merged. I'll prepare a backport for all three of them 👍 |
thaJeztah
added
status/4-merge
process/cherry-picked
and removed
process/cherry-pick
impact/changelog
impact/deprecation
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
relates to / depends on:
Our templates no longer contain version-specific rules, so this function is no longer used. This patch deprecates it.
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)