Skip to content

[23.0 backport] d/graphdriver/copy: support src fs w/o xattr support#45465

Merged
thaJeztah merged 1 commit intomoby:23.0from
corhere:backport-23.0/copy-xattr-notsupp
May 4, 2023
Merged

[23.0 backport] d/graphdriver/copy: support src fs w/o xattr support#45465
thaJeztah merged 1 commit intomoby:23.0from
corhere:backport-23.0/copy-xattr-notsupp

Conversation

@corhere
Copy link
Copy Markdown
Contributor

@corhere corhere commented May 4, 2023

Treat copying extended attributes from a source filesystem which does not support extended attributes as a no-op, same as if the file did not possess the extended attribute. Only fail copying extended attributes if the source file has the attribute and the destination filesystem does not support xattrs.

(cherry picked from commit 2b6761f)

- What I did

- How I did it

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

Treat copying extended attributes from a source filesystem which does
not support extended attributes as a no-op, same as if the file did not
possess the extended attribute. Only fail copying extended attributes if
the source file has the attribute and the destination filesystem does
not support xattrs.

Signed-off-by: Cory Snider <[email protected]>
(cherry picked from commit 2b6761f)
Signed-off-by: Cory Snider <[email protected]>
@corhere corhere added the area/storage Image Storage label May 4, 2023
@corhere corhere added this to the 23.0.6 milestone May 4, 2023
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah
Copy link
Copy Markdown
Member

Failure is a known flaky and unrelated (TestRunContainerWithRmFlagCannotStartContainer)

@thaJeztah thaJeztah merged commit 24fd7c5 into moby:23.0 May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants