[23.0 backport] Use the image service instead of the reference store for tagging#45410
Merged
Merged
Conversation
The image store sends events when a new image is created/tagged, using it instead of the reference store makes sure we send the "tag" event when a new image is built using buildx. Signed-off-by: Djordje Lukic <[email protected]>
thaJeztah
added
area/builder
thaJeztah
reviewed
Apr 26, 2023
| } | ||
|
|
||
| type ImageTagger interface { | ||
| TagImageWithReference(imageID image.ID, newTag reference.Named) error |
Member
There was a problem hiding this comment.
For others; master diverged; on master, this is;
Suggested change
| TagImageWithReference(imageID image.ID, newTag reference.Named) error | |
| TagImage(ctx context.Context, imageID image.ID, newTag distref.Named) error |
crazy-max
approved these changes
Apr 26, 2023
vvoland
approved these changes
Apr 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Changed the way
mobyexportertags an image, it used to use the reference store which doesn't send image events, we now use the image service to tag the new image. This makes sure we send the "tag" event when an image is built withbuildx.Note: this was a long standing issue when building an image with buildx but it only came up now because buildx is the default builder since 23.0
- How I did it
- How to verify it