Skip to content

Comments

daemon: remove deprecated AuFS storage driver#45342

Merged
tianon merged 1 commit intomoby:masterfrom
thaJeztah:remove_deprecated_aufs_storage_driver
Apr 18, 2023
Merged

daemon: remove deprecated AuFS storage driver#45342
tianon merged 1 commit intomoby:masterfrom
thaJeztah:remove_deprecated_aufs_storage_driver

Conversation

@thaJeztah
Copy link
Member

Relates to;


There's still some locations refering to AuFS;

  • pkg/archive: I suspect most of that code is because the whiteout-files are modelled after aufs (but possibly some code is only relevant to images created with AuFS as storage driver; to be looked into).
  • contrib/apparmor/template: likely some rules can be removed
  • contrib/dockerize-disk.sh: very old contribution, and unlikely used by anyone, but perhaps could be updated if we want to (or just removed).

- What I did

- How I did it

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

There's still some locations refering to AuFS;

- pkg/archive: I suspect most of that code is because the whiteout-files
  are modelled after aufs (but possibly some code is only relevant to
  images created with AuFS as storage driver; to be looked into).
- contrib/apparmor/template: likely some rules can be removed
- contrib/dockerize-disk.sh: very old contribution, and unlikely used
  by anyone, but perhaps could be updated if we want to (or just removed).

Signed-off-by: Sebastiaan van Stijn <[email protected]>
Copy link
Member

@tianon tianon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vigorously LGTM

func checkRemoved(name string) error {
switch name {
case "aufs":
return NotSupportedError(fmt.Sprintf("[graphdriver] ERROR: the %s storage-driver has been deprecated and removed; visit https://docs.docker.com/go/storage-driver/ for more information", name))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to update that docs page to make it more clear that AuFS usage is heavily discouraged (and once this merges, outright removed)? 😇

@tianon tianon merged commit bbb94fd into moby:master Apr 18, 2023
@thaJeztah thaJeztah deleted the remove_deprecated_aufs_storage_driver branch April 19, 2023 02:02
@thaJeztah thaJeztah added this to the 24.0.0 milestone Apr 19, 2023
@thaJeztah
Copy link
Member Author

/cc @dvdksn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants