container: split security options to a SecurityOptions struct#45338
Merged
thaJeztah merged 1 commit intomoby:masterfrom May 4, 2023
Merged
container: split security options to a SecurityOptions struct#45338thaJeztah merged 1 commit intomoby:masterfrom
thaJeztah merged 1 commit intomoby:masterfrom
Conversation
thaJeztah
added
status/2-code-review
area/daemon
thaJeztah
force-pushed
the
split_securityoptions
branch
2 times, most recently
from
fc0e532 to
53597d2
Compare
- Split these options to a separate struct, so that we can handle them in isolation. - Change some tests to use subtests, and improve coverage Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
split_securityoptions
branch
from
53597d2 to
3eebf4d
Compare
3 tasks
Member
Author
tianon
approved these changes
May 3, 2023
vvoland
approved these changes
May 4, 2023
rumpl
approved these changes
May 4, 2023
Member
Author
|
Thanks! Failures are |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
some changes I had lying around locally (may still need some finishing up), but recalled I had them when I looked at
Add no-new-privileges to SecurityOptions returned by /info #45320
Split these options to a separate struct, so that we can handle them in isolation.
Change some tests to use subtests, and improve coverage
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)