daemon/config: fix default-network-opts in daemon.json#45264
Merged
thaJeztah merged 1 commit intomoby:masterfrom Apr 4, 2023
Merged
daemon/config: fix default-network-opts in daemon.json#45264thaJeztah merged 1 commit intomoby:masterfrom
thaJeztah merged 1 commit intomoby:masterfrom
Conversation
corhere
added
status/2-code-review
area/daemon
Member
|
do we have a test somewhere where we could add this to? |
Prevent the daemon from erroring out if daemon.json contains default network options for network drivers aside from bridge. Configuring defaults for the bridge driver previously worked by coincidence because the unrelated CLI flag '--bridge' exists. Signed-off-by: Cory Snider <[email protected]>
corhere
force-pushed
the
fix-default-network-opts-config
branch
from
cb92059 to
750218c
Compare
Contributor
Author
|
Good call @thaJeztah; I've added a regression test. |
Member
vvoland
approved these changes
Apr 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you @richardg867 for reporting the issue.
- What I did
Prevent the daemon from erroring out if daemon.json contains default network options for network drivers aside from bridge. Configuring defaults for the bridge driver previously worked by coincidence because the unrelated CLI flag
‑‑bridgeexists.- How I did it
Added
"default-network-opts"to theflatOptionsset.- How to verify it
With the following configuration, the daemon starts up and newly created overlay networks have the mtu option applied by default.
- Description for the changelog
N/A; bugfix for unreleased feature
- A picture of a cute animal (not mandatory but encouraged)