Fix listener parsering regression when no addr set#45132
Merged
neersighted merged 1 commit intomoby:masterfrom Mar 10, 2023
Merged
Fix listener parsering regression when no addr set#45132neersighted merged 1 commit intomoby:masterfrom
neersighted merged 1 commit intomoby:masterfrom
Conversation
cpuguy83
force-pushed
the
fix_listener_regression
branch
from
55ddac9 to
6eb33d1
Compare
Member
|
oh! failure on Windows; |
5008409 introduced the usage of `strings.Cut` to help parse listener addresses. Part of that also made it error out if no addr is specified after the protocol spec (e.g. `tcp://`). Before the change a proto spec without an address just used the default address for that proto. e.g. `tcp://` would be `tcp://127.0.0.1:2375`, `unix://` would be `unix:///var/run/docker.sock`. Critically, socket activation (`fd://`) never has an address. This change brings back the old behavior but keeps the usage of `strings.Cut`. Signed-off-by: Brian Goff <[email protected]>
cpuguy83
force-pushed
the
fix_listener_regression
branch
from
6eb33d1 to
37a9d6a
Compare
thaJeztah
added
status/2-code-review
area/daemon
neersighted
approved these changes
Mar 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
5008409 introduced the usage of
strings.Cutto help parse listener addresses.Part of that also made it error out if no addr is specified after the protocol spec (e.g.
tcp://).Before the change a proto spec without an address just used the default address for that proto.
e.g.
tcp://would betcp://127.0.0.1:2375,unix://would beunix:///var/run/docker.sock.Critically, socket activation (
fd://) never has an address.This change brings back the old behavior but keeps the usage of
strings.Cut.Closes #44823