[23.0] Fix nil pointer dereference when attempting to log DNS errors#44980
Merged
Conversation
Contributor
|
Duplicate of #44664 |
Contributor
|
#44664 will fix this bug on master, but it is too big and invasive to backport to 23.0 in its entirety. This PR could be the 23.0 backport! |
If the resolver encounters an error before it attempts to forward the request to external DNS, do not try to log information about the external connection, because at this point `extConn` is `nil`. This makes sure `dockerd` won't panic and crash from a nil pointer dereference when it sees an invalid DNS query. fixes moby#44979 Signed-off-by: er0k <[email protected]>
corhere
changed the title
corhere
added
status/2-code-review
area/networking
corhere
approved these changes
Feb 13, 2023
akerouanton
approved these changes
Feb 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #44979
- What I did
This makes sure
dockerdwon't panic and crash from a nil pointer dereference when it sees an invalid DNS query.- How I did it
If the resolver encounters an error before it attempts to forward the request to external DNS, do not try to log information about the external connection, because at this point
extConnisnil- How to verify it
🧐
- Description for the changelog
Fix nil pointer dereference when attempting to log DNS errors
- A picture of a cute animal (not mandatory but encouraged)
