manage image inspect data in backend#44622
Merged
thaJeztah merged 2 commits intomoby:masterfrom Dec 12, 2022
Merged
Conversation
Signed-off-by: Sebastiaan van Stijn <[email protected]>
This allows differentiating how the detailed data is collected between the containerd-integration code and the existing implementation. Signed-off-by: Nicolas De Loof <[email protected]> Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
added
status/2-code-review
area/images
Member
Author
|
@rumpl @corhere @tianon I was working on #43818 / #44621 and noticed that some squashing and reorganising may be needed, so I extracted the first (non-containers integration) changes of #44080) so that we can verify this doesn't affect the existing implementation, and so that the remaining changes are focussing on implementing things for the containerd-integration itself. PTAL (after this is merged, I'll rebase the other one) |
rumpl
approved these changes
Dec 12, 2022
vvoland
approved these changes
Dec 12, 2022
tianon
approved these changes
Dec 12, 2022
Member
Author
|
Thanks! Let me bring this one in 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
manage image inspect data in backend
This allows differentiating how the detailed data is collected between
the containerd-integration code and the existing implementation.
This PR is a subset of the changes in rumpl#27, and only implements the changes for the existing backend. Changes for the containerd-integration variant are done in #44621