[draft] containerd integration: add support for image inspect#44621
Closed
thaJeztah wants to merge 11 commits intomoby:masterfrom
Closed
[draft] containerd integration: add support for image inspect#44621thaJeztah wants to merge 11 commits intomoby:masterfrom
thaJeztah wants to merge 11 commits intomoby:masterfrom
Conversation
thaJeztah
force-pushed
the
image_inspect_step2
branch
from
e60adc3 to
73eef4e
Compare
thaJeztah
force-pushed
the
image_inspect_step2
branch
3 times, most recently
from
63bbb2c to
ac08e60
Compare
vvoland
approved these changes
Dec 13, 2022
Contributor
vvoland
left a comment
vvoland
left a comment
There was a problem hiding this comment.
Is there something else that needs to be done for this one?
rumpl
approved these changes
Dec 13, 2022
rumpl
reviewed
Dec 13, 2022
| User: ociimage.Config.User, | ||
| WorkingDir: ociimage.Config.WorkingDir, | ||
| ExposedPorts: exposedPorts, | ||
| Volumes: ociimage.Config.Volumes, |
Member
Author
There was a problem hiding this comment.
Ah, I have that one in a branch for a follow-up, in case we still need a discussion (didn't want that discussion to block these changes).
Member
Author
@vvoland I think the only thing left (from my side) is to cleanup the commits / squash things; but code changes should already be good for review, so I'll have a look at doing so. |
thaJeztah
added
status/2-code-review
containerd-integration
Signed-off-by: Nicolas De Loof <[email protected]> Signed-off-by: Sebastiaan van Stijn <[email protected]>
…present
It's horrible, but some clients (such as the docker 17.03 CLI used in CI) still
perform string-matching to detect that the *image* wasn't found. This requires
the error to be prefixed with "No such image:". Without this prefix, the CLI
prints the error message, and exits.
Before this:
docker run -it --rm hello-world
docker: Error response from daemon: id not found.
See 'docker run --help'.
After this:
docker run -it --rm hello-world
Unable to find image 'hello-world:latest' locally
faa03e786c97: Download complete
...
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Nicolas De Loof <[email protected]> Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Nicolas De Loof <[email protected]> Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Nicolas De Loof <[email protected]>
Signed-off-by: Djordje Lukic <[email protected]>
There were a lot of useless duplicated code Signed-off-by: Djordje Lukic <[email protected]> Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Djordje Lukic <[email protected]>
Signed-off-by: Nicolas De Loof <[email protected]>
Signed-off-by: Nicolas De Loof <[email protected]> Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
image_inspect_step2
branch
from
ac08e60 to
b642809
Compare
Member
Author
|
closing this one; superseded by #43818 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This upstreams a set of (partial) patches:
These patches were selected by looking at the history for https://github.com/rumpl/moby/commits/dd-4.15.0/daemon/containerd/image.go, and only the relevant parts for this feature were included.
Quite a few of those are touching-up previous commits, so we should consider squashing (some of) them, but keeping them separate for now to somewhat help review.
Also included rumpl#122