[20.10] vendor: github.com/moby/libnetwork dcdf8f176d1e13ad719e913e796fb698d846de98#44476
Merged
Conversation
neersighted
requested changes
Nov 16, 2022
neersighted
left a comment
neersighted
left a comment
Member
There was a problem hiding this comment.
Updating repository references is fine, but the import path is still docker/libnetwork and cannot change.
Everything but the git clone needs to revert to the old name.
Member
|
Also, could you please rephrase your commit message to conform to the repo convention for vendoring? e.g. 2570784 |
sbuckfelder
force-pushed
the
20.10_UPDATE
branch
from
November 17, 2022 12:18
c42838d to
845c326
Compare
sbuckfelder
changed the title
Author
Updated in new rev |
Author
I believe I was able to follow this advice in the new rev, please let me know if not. |
neersighted
approved these changes
Nov 17, 2022
Member
|
This looks good from a changes made standpoint, but fails the vendoring checks. Did you vendor by hand instead of using vndr?
You should run |
thaJeztah
added
status/2-code-review
area/networking
…6fb698d846de98 Co-authored-by: Sebastiaan van Stijn <[email protected]> Signed-off-by: Scott Buckfelder <[email protected]>
thaJeztah
force-pushed
the
20.10_UPDATE
branch
from
November 23, 2022 19:27
845c326 to
72b9ba4
Compare
Member
|
I amended the commit and ran vendor |
thaJeztah
approved these changes
Nov 23, 2022
thaJeztah
left a comment
thaJeztah
left a comment
Member
There was a problem hiding this comment.
LGTM (assuming CI is happy)
thaJeztah
removed
the
status/failing-ci
paralin
added a commit
to skiffos/buildroot
that referenced
this pull request
Jan 13, 2023
Bug fixes and enhancements - Improve error message when attempting to pull an unsupported image format or OCI artifact (moby/moby#44413, moby/moby#44569) - Fix an issue where the host's ephemeral port-range was ignored when selecting random ports for containers (moby/moby#44476). - Fix ssh: parse error in message type 27 errors during docker build on hosts using OpenSSH 8.9 or above (moby/moby#3862). - seccomp: block socket calls to AF_VSOCK in default profile (moby/moby#44564). https://github.com/moby/moby/releases/tag/v20.10.22 Signed-off-by: Christian Stewart <[email protected]>
paralin
added a commit
to skiffos/buildroot
that referenced
this pull request
Jan 13, 2023
Bug fixes and enhancements - Improve error message when attempting to pull an unsupported image format or OCI artifact (moby/moby#44413, moby/moby#44569) - Fix an issue where the host's ephemeral port-range was ignored when selecting random ports for containers (moby/moby#44476). - Fix ssh: parse error in message type 27 errors during docker build on hosts using OpenSSH 8.9 or above (moby/moby#3862). - seccomp: block socket calls to AF_VSOCK in default profile (moby/moby#44564). https://github.com/moby/moby/releases/tag/v20.10.22 Signed-off-by: Christian Stewart <[email protected]>
arnout
pushed a commit
to buildroot/buildroot
that referenced
this pull request
Jan 14, 2023
Bug fixes and enhancements - Improve error message when attempting to pull an unsupported image format or OCI artifact (moby/moby#44413, moby/moby#44569) - Fix an issue where the host's ephemeral port-range was ignored when selecting random ports for containers (moby/moby#44476). - Fix ssh: parse error in message type 27 errors during docker build on hosts using OpenSSH 8.9 or above (moby/moby#3862). - seccomp: block socket calls to AF_VSOCK in default profile (moby/moby#44564). https://github.com/moby/moby/releases/tag/v20.10.22 Signed-off-by: Christian Stewart <[email protected]> Signed-off-by: Peter Korsgaard <[email protected]>
arnout
pushed a commit
to buildroot/buildroot
that referenced
this pull request
Jan 15, 2023
Bug fixes and enhancements - Improve error message when attempting to pull an unsupported image format or OCI artifact (moby/moby#44413, moby/moby#44569) - Fix an issue where the host's ephemeral port-range was ignored when selecting random ports for containers (moby/moby#44476). - Fix ssh: parse error in message type 27 errors during docker build on hosts using OpenSSH 8.9 or above (moby/moby#3862). - seccomp: block socket calls to AF_VSOCK in default profile (moby/moby#44564). https://github.com/moby/moby/releases/tag/v20.10.22 Signed-off-by: Christian Stewart <[email protected]> Signed-off-by: Peter Korsgaard <[email protected]> (cherry picked from commit de51efc) Signed-off-by: Peter Korsgaard <[email protected]>
arnout
pushed a commit
to buildroot/buildroot
that referenced
this pull request
Jan 15, 2023
Bug fixes and enhancements - Improve error message when attempting to pull an unsupported image format or OCI artifact (moby/moby#44413, moby/moby#44569) - Fix an issue where the host's ephemeral port-range was ignored when selecting random ports for containers (moby/moby#44476). - Fix ssh: parse error in message type 27 errors during docker build on hosts using OpenSSH 8.9 or above (moby/moby#3862). - seccomp: block socket calls to AF_VSOCK in default profile (moby/moby#44564). https://github.com/moby/moby/releases/tag/v20.10.22 Signed-off-by: Christian Stewart <[email protected]> Signed-off-by: Peter Korsgaard <[email protected]> (cherry picked from commit de51efc) Signed-off-by: Peter Korsgaard <[email protected]>
ccrisan
pushed a commit
to ccrisan/thingos
that referenced
this pull request
Jun 26, 2025
Bug fixes and enhancements - Improve error message when attempting to pull an unsupported image format or OCI artifact (moby/moby#44413, moby/moby#44569) - Fix an issue where the host's ephemeral port-range was ignored when selecting random ports for containers (moby/moby#44476). - Fix ssh: parse error in message type 27 errors during docker build on hosts using OpenSSH 8.9 or above (moby/moby#3862). - seccomp: block socket calls to AF_VSOCK in default profile (moby/moby#44564). https://github.com/moby/moby/releases/tag/v20.10.22 Signed-off-by: Christian Stewart <[email protected]> Signed-off-by: Peter Korsgaard <[email protected]>
ccrisan
pushed a commit
to qtoggle/qtoggleos
that referenced
this pull request
Oct 21, 2025
Bug fixes and enhancements - Improve error message when attempting to pull an unsupported image format or OCI artifact (moby/moby#44413, moby/moby#44569) - Fix an issue where the host's ephemeral port-range was ignored when selecting random ports for containers (moby/moby#44476). - Fix ssh: parse error in message type 27 errors during docker build on hosts using OpenSSH 8.9 or above (moby/moby#3862). - seccomp: block socket calls to AF_VSOCK in default profile (moby/moby#44564). https://github.com/moby/moby/releases/tag/v20.10.22 Signed-off-by: Christian Stewart <[email protected]> Signed-off-by: Peter Korsgaard <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Scott Buckfelder [email protected]
Issue : #44423
fixes #43054
Merges in commit moby/libnetwork#2668 which is a backport of functionality.
Note For Reviewers : I also updated the hack/dockerfile/install/proxy.installer file to now reference moby/libnetwork as opposed to docker/libnetwork. I'm not terribly confident this was the correct thing to do.