fix vendor.mod: add hashicorp/go-multierror as direct dependency#44453
Merged
thaJeztah merged 1 commit intomoby:masterfrom Nov 14, 2022
Merged
fix vendor.mod: add hashicorp/go-multierror as direct dependency#44453thaJeztah merged 1 commit intomoby:masterfrom
thaJeztah merged 1 commit intomoby:masterfrom
Conversation
Starting with 2bdc7fb, the github.com/hashicorp/go-multierror module is a direct dependency. Signed-off-by: Sebastiaan van Stijn <[email protected]>
This was referenced Nov 14, 2022
neersighted
approved these changes
Nov 14, 2022
Member
Author
|
BuildKit failures are unrelated, and will be fixed in #44452. See #44452 (comment) |
Member
|
It looks like golang/go#27005 is what would provide a built-in fast path for this case; however, implementing something ourselves with |
Member
Author
|
Thanks! Yes, mostly want to prevent doing a full vendor update (if not needed), so if there's a way to check without running the actual vendoring, that'd be nice |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starting with 2bdc7fb (#44210), the github.com/hashicorp/go-multierror module is a direct dependency.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)