[20.10 backport] skip TestImagePullStoredfDigestForOtherRepo() on Windows and rootless#44340
Merged
Merged
Conversation
- On Windows, we don't build and run a local test registry (we're not running docker-in-docker), so we need to skip this test. - On rootless, networking doesn't support this (currently) Signed-off-by: Sebastiaan van Stijn <[email protected]> (cherry picked from commit 4f43cb6) Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
added
status/2-code-review
area/testing
kind/bugfix
thaJeztah
commented
Oct 21, 2022
thaJeztah
left a comment
thaJeztah
left a comment
Member
Author
There was a problem hiding this comment.
"LGTM" - CI is happy now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
taken from Validate digest in repo for pull by digest #44327
On Windows, we don't build and run a local test registry (we're not running docker-in-docker), so we need to skip this test.
On rootless, networking doesn't support this (currently)
(cherry picked from commit 4f43cb6)