[20.10] vendor: github.com/moby/buildkit eeb7b65ab7d651770a5ec52a06ea7c96eb97a249 (v0.8 branch)#44339
Merged
Merged
Conversation
thaJeztah
added
impact/changelog
area/builder/buildkit
Member
|
@crazy-max looks like some additional packages have to be pulled into vendor; |
Member
Author
|
Ahhh indeed I was still in the go modules world my bad. |
Member
|
I think usually it adds them with |
crazy-max
force-pushed
the
20.10_update_buildkit
branch
from
October 20, 2022 22:58
85f6424 to
9038eae
Compare
Member
Author
Yes was a new one |
Member
|
Failures will be fixed once #44340 is merged |
Member
|
Almost green now; wondering if it would be newline or whitespace changes. Let me try to run a vendor on this branch; |
Member
|
ah! |
…7c96eb97a249 (v0.8 branch) Signed-off-by: CrazyMax <[email protected]> Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
20.10_update_buildkit
branch
from
October 21, 2022 15:40
9038eae to
e83e465
Compare
thaJeztah
approved these changes
Oct 21, 2022
thaJeztah
left a comment
thaJeztah
left a comment
Member
There was a problem hiding this comment.
all green now, thanks!
LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)