gha: buildkit: remove "skip-integration-tests" from matrix#44337
Merged
Conversation
Signed-off-by: Sebastiaan van Stijn <[email protected]>
GitHub uses these parameters to construct a name; removing the ./ prefix to make them more readable (and add them back where it's used) Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
buildkit_skip_unit
branch
from
October 20, 2022 21:20
80b5f42 to
0760c6f
Compare
Member
Author
|
This will fail until #44336 is in; I'll rebase after that |
crazy-max
approved these changes
Oct 20, 2022
tianon
approved these changes
Oct 20, 2022
corhere
approved these changes
Oct 20, 2022
Member
Author
|
Wait; why does BuildKit CI pass on this PR? Shouldn't it fail because #44336 isn't merged yet? |
Member
Author
Ah! Nevermind; the other failures were in the parts I'm removing here and the tests to skip were not part of the BuildKit version we were using before. Bringing this one in 👍 |
This was referenced Oct 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.