[20.10 backport] registry: allow "allow-nondistributable-artifacts" for Docker Hub#44313
Merged
Conversation
Previously, Docker Hub was excluded when configuring "allow-nondistributable-artifacts". With the updated policy announced by Microsoft, we can remove this restriction; https://techcommunity.microsoft.com/t5/containers/announcing-windows-container-base-image-redistribution-rights/ba-p/3645201 There are plans to deprecated support for foreign layers altogether in the OCI, and we should consider to make this option the default, but as that requires deprecating the option (and possibly keeping an "opt-out" option), we can look at that separately. (cherry picked from commit 30e5333) Signed-off-by: Sebastiaan van Stijn <[email protected]> Signed-off-by: Tianon Gravi <[email protected]>
tianon
force-pushed
the
20.10-distributable
branch
from
October 17, 2022 22:12
47e6bf8 to
6699afa
Compare
thaJeztah
marked this pull request as draft
October 17, 2022 22:19
thaJeztah
approved these changes
Oct 17, 2022
thaJeztah
left a comment
thaJeztah
left a comment
Member
There was a problem hiding this comment.
LGTM
moved it to draft as some other changes have to go in first.
Could you open a backport for 22.06 as well?
Member
|
ah! Found the 22.06 one; thanks! |
thaJeztah
added
area/distribution
thaJeztah
marked this pull request as ready for review
October 18, 2022 19:51
Member
Author
|
This one is OK now? 😇 |
Member
|
I think it is 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #44305
(cherry picked from commit 30e5333)