migrate pkg/pubsub to github.com/moby/pubsub#44221
Merged
thaJeztah merged 1 commit intomoby:masterfrom Sep 30, 2022
Merged
Conversation
thaJeztah
added
status/2-code-review
process/cherry-pick
kind/refactor
Member
Author
corhere
approved these changes
Sep 30, 2022
Contributor
corhere
left a comment
corhere
left a comment
There was a problem hiding this comment.
Since it's already in production use, the github.com/moby/pubsub module should have a v1.0.0 release.
Member
Author
|
Yes, a v1.0.0 is probably ok; I guess just some minor touching up to do in the repository (add a minimal github actions to run tests), and we should be fine I think |
cpuguy83
approved these changes
Sep 30, 2022
Member
Author
|
I opened moby/pubsub#1 to add github actions to the repository |
Member
Author
|
Go Actions were added and happy. Let me tag a v1.0.0 and update this PR, then we should be all set (and we don't need to do a follow-up to update the version) |
This package was moved to a separate repository, using the steps below:
# install filter-repo (https://github.com/newren/git-filter-repo/blob/main/INSTALL.md)
brew install git-filter-repo
cd ~/projects
# create a temporary clone of docker
git clone https://github.com/docker/docker.git moby_pubsub_temp
cd moby_pubsub_temp
# for reference
git rev-parse HEAD
# --> 572ca79
# remove all code, except for pkg/pubsub, license, and notice, and rename pkg/pubsub to /
git filter-repo --path pkg/pubsub/ --path LICENSE --path NOTICE --path-rename pkg/pubsub/:
# remove canonical imports
git revert -s -S 585ff0ebbe6bc25b801a0e0087dd5353099cb72e
# initialize module
go mod init github.com/moby/pubsub
go mod tidy
Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
migrate_pubsub
branch
from
780f4c7 to
0249afc
Compare
Member
Author
|
Updated to v1.0.0 👍 |
This was referenced Sep 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This package was moved to a separate repository, using the steps below:
- A picture of a cute animal (not mandatory but encouraged)