hack/install: Update docker-cli source, add missing platforms#44214
hack/install: Update docker-cli source, add missing platforms#44214vvoland wants to merge 3 commits intomoby:masterfrom
Conversation
|
|
||
| : ${DOCKERCLI_CHANNEL:=stable} | ||
| : ${DOCKERCLI_VERSION:=17.06.2-ce} | ||
| : ${DOCKERCLI_VERSION:=18.06.3-ce} |
There was a problem hiding this comment.
Do we have to stick to the -ce versions here, or could it be the current 20.10.18?
There was a problem hiding this comment.
There should be no requirement to use -ce as far as I know -- 20.10.18 should be perfectly safe.
There was a problem hiding this comment.
Discussed in maintainer's call: we can't go too new as the deprecated integration-cli tests in this repo will not function with a newer CLI. This is a fine stepping stone, but in the medium term we should install a pinned old CLI (and freeze it) until the integration-cli tests can be migrated to API tests or CLI e2e tests. In the long term, we should remove the CLI from this repo entirely except as a convenience feature for the defcontainer.
vvoland
force-pushed
the
hack-installer-dockercli
branch
from
ffe8f05 to
a0c7b30
Compare
Signed-off-by: Paweł Gronowski <[email protected]>
Signed-off-by: Paweł Gronowski <[email protected]>
Signed-off-by: Paweł Gronowski <[email protected]>
vvoland
force-pushed
the
hack-installer-dockercli
branch
from
a0c7b30 to
9b86951
Compare
neersighted
left a comment
neersighted
left a comment
There was a problem hiding this comment.
LGTM, though I would prefer a newer version
|
|
||
| : ${DOCKERCLI_CHANNEL:=stable} | ||
| : ${DOCKERCLI_VERSION:=17.06.2-ce} | ||
| : ${DOCKERCLI_VERSION:=18.06.3-ce} |
There was a problem hiding this comment.
There should be no requirement to use -ce as far as I know -- 20.10.18 should be perfectly safe.
4 participants
Since the docker-ce repo is deprecated, change the source repository used for building the cli to docker/cli.
The cli will also be built from source, if the binary download fails.
Add platforms which binaries are available on the download.docker.com, but are missing in the installer.
Also, added a fallback to building the cli from source when the binary download fails.
- A picture of a cute animal (not mandatory but encouraged)