[22.06 backport] refactor(pkg/archive): factor out createImpliedDirectories helper#44207
Merged
thaJeztah merged 2 commits intomoby:22.06from Sep 27, 2022
Merged
Conversation
Member
neersighted
commented
Sep 27, 2022
neersighted
commented
- backport of refactor(pkg/archive): factor out createImpliedDirectories helper #44196 to 22.06
- refactor(pkg/archive): factor out createImpliedDirectories helper
- test(pkg/archive): add TestImpliedDirectoryPermissions
This code was duplicated in two places -- factor it out, add documentation, and move magic numbers into a constant. Additionally, use the same permissions (0755) in both code paths, and ensure that the ID map is used in both code paths. Co-authored-by: Vasiliy Ulyanov <[email protected]> Signed-off-by: Bjorn Neergaard <[email protected]> Signed-off-by: Vasiliy Ulyanov <[email protected]> (cherry picked from commit 4831ff9)
Co-authored-by: Cory Snider <[email protected]> Signed-off-by: Bjorn Neergaard <[email protected]> (cherry picked from commit 5dff494)
neersighted
added
status/2-code-review
area/images
corhere
approved these changes
Sep 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.