Skip to content

[20.10 backport] fix local context#44109

Merged
cpuguy83 merged 1 commit into
moby:20.10from
rumpl:20.10-fix-local-context
Sep 8, 2022
Merged

[20.10 backport] fix local context#44109
cpuguy83 merged 1 commit into
moby:20.10from
rumpl:20.10-fix-local-context

Conversation

@rumpl

@rumpl rumpl commented Sep 7, 2022

Copy link
Copy Markdown
Member

@rumpl
rumpl requested a review from thaJeztah September 7, 2022 13:16
@thaJeztah thaJeztah added status/2-code-review area/images Image Service kind/bugfix PR's that fix bugs labels Sep 7, 2022
@thaJeztah thaJeztah added this to the 20.10.18 milestone Sep 7, 2022
thaJeztah
thaJeztah previously approved these changes Sep 7, 2022

@thaJeztah thaJeztah left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah
thaJeztah dismissed their stale review September 7, 2022 18:01

Looks like build is failing

@thaJeztah

This comment was marked as resolved.

The wrapper sets the default namespace in the context if none is
provided, this is needed because we are calling these services directly
and not trough GRPC that has an interceptor to set the default namespace
to all calls.

Signed-off-by: Djordje Lukic <[email protected]>
(cherry picked from commit 8789066)
Signed-off-by: Djordje Lukic <[email protected]>
@rumpl
rumpl force-pushed the 20.10-fix-local-context branch from f916fd9 to 6a0186b Compare September 8, 2022 14:57

@thaJeztah thaJeztah left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah

Copy link
Copy Markdown
Member

@corhere @cpuguy83 PTAL

@cpuguy83
cpuguy83 merged commit d348775 into moby:20.10 Sep 8, 2022
@thaJeztah
thaJeztah deleted the 20.10-fix-local-context branch September 8, 2022 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants