Dockerfile: pin criu version and build from source#44086
Dockerfile: pin criu version and build from source#44086crazy-max wants to merge 1 commit intomoby:masterfrom
Conversation
crazy-max
force-pushed
the
criu-src
branch
2 times, most recently
from
9d36239 to
98f888c
Compare
|
@tianon PTAL (sorry, looks like we're going back-and-forth on pre-built vs compile, but these package-repos are not very stable) |
|
:sadpanda: I really don't want to have to build this from source every time. Yeah it gets cached, but I don't always have the build cached. |
Co-Authored-By: CrazyMax <[email protected]> Signed-off-by: Prabhav Thali <[email protected]>
|
I would like to see this (or some other approach) merged as it's bit me a few times -- can we reach consensus on this approach? |
|
@cpuguy83 is that a "strong" no, or would you be ok with having this as an (intermediate?) solution? @crazy-max also mentioned that the package is not available for armhf and riscv (but criu itself does support it? albeit still WIP); ideally that would be fixed in the SUSE repo of course. While discussing; I was also looking where we actually use CRIU; I think this was for the integration tests, but it looks like the actual tests were broken, and currently skipped. For fun, I opened #44495 to see if they actually work. |
pin criu for better reproducibility and build from source. will solve issues we have with flakiness using the opensuse mirror but also being able to build on other platforms Signed-off-by: CrazyMax <[email protected]>
crazy-max
force-pushed
the
criu-src
branch
2 times, most recently
from
202f248 to
759b6d7
Compare
|
I'm against doing that. This increases test time, creates some extra build logs, and in general is a waste of resources, especially since this PR builds the same criu version over and over. |
thaJeztah
added
the
area/checkpoint
6 participants
related to #43529
- What I did
pin criu for better reproducibility and build from source.
will solve issues we have with flakiness using the opensuse mirror
but also being able to build on other platforms:
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)
Signed-off-by: CrazyMax [email protected]