manage image inspect data in backend#44080
Closed
ndeloof wants to merge 1 commit intomoby:masterfrom
Closed
Conversation
Signed-off-by: Nicolas De Loof <[email protected]>
thaJeztah
added
status/2-code-review
area/images
thaJeztah
reviewed
Sep 1, 2022
| // GetImage returns an image corresponding to the image referred to by refOrID. | ||
| func (i *ImageService) GetImage(refOrID string, options imagetype.GetImageOpts) (retImg *image.Image, retErr error) { | ||
| panic("not implemented") | ||
| func (i *ImageService) GetImage(ctx context.Context, refOrID string, options imagetype.GetImageOpts) (*image.Image, error) { |
Member
There was a problem hiding this comment.
This PR probably depends on the context changes and/or "inspect" change to go in first;
- containerd integration: imageservice: add contexts to various methods (step 1) #43939
- containerd integration: imageservice: add contexts to various methods #43828
- add support for image inspect with containerd-integration #43818
#41 0.150 ---> Making bundle: binary (in /build/bundles/binary)
#41 0.186 Building: /build/bundles/binary-daemon/dockerd
#41 0.186 GOOS="" GOARCH="" GOARM=""
#41 44.98 # github.com/docker/docker/daemon/images
#41 44.98 daemon/images/cache.go:19:31: not enough arguments in call to i.GetImage
#41 44.98 have (string, "github.com/docker/docker/api/types/image".GetImageOpts)
#41 44.98 want (context.Context, string, "github.com/docker/docker/api/types/image".GetImageOpts)
#41 44.98 daemon/images/image_builder.go:171:31: not enough arguments in call to i.GetImage
#41 44.98 have (string, "github.com/docker/docker/api/types/image".GetImageOpts)
#41 44.98 want (context.Context, string, "github.com/docker/docker/api/types/image".GetImageOpts)
#41 44.98 daemon/images/image_builder.go:215:35: not enough arguments in call to i.GetImage
#41 44.98 have (string, "github.com/docker/docker/api/types/image".GetImageOpts)
#41 44.98 want (context.Context, string, "github.com/docker/docker/api/types/image".GetImageOpts)
#41 44.98 daemon/images/image_delete.go:67:35: not enough arguments in call to i.GetImage
#41 44.98 have (string, "github.com/docker/docker/api/types/image".GetImageOpts)
#41 44.98 want (context.Context, string, "github.com/docker/docker/api/types/image".GetImageOpts)
#41 44.98 daemon/images/image_events.go:15:34: not enough arguments in call to i.GetImage
#41 44.98 have (string, "github.com/docker/docker/api/types/image".GetImageOpts)
#41 44.98 want (context.Context, string, "github.com/docker/docker/api/types/image".GetImageOpts)
#41 44.98 daemon/images/image_history.go:16:31: not enough arguments in call to i.GetImage
#41 44.98 have (string, "github.com/docker/docker/api/types/image".GetImageOpts)
#41 44.98 want (context.Context, string, "github.com/docker/docker/api/types/image".GetImageOpts)
#41 44.98 daemon/images/image_history.go:72:42: not enough arguments in call to i.GetImage
#41 44.98 have (string, "github.com/docker/docker/api/types/image".GetImageOpts)
#41 44.98 want (context.Context, string, "github.com/docker/docker/api/types/image".GetImageOpts)
#41 44.98 daemon/images/image_list.go:53:41: not enough arguments in call to i.GetImage
#41 44.98 have (string, "github.com/docker/docker/api/types/image".GetImageOpts)
#41 44.98 want (context.Context, string, "github.com/docker/docker/api/types/image".GetImageOpts)
#41 44.98 daemon/images/image_list.go:61:40: not enough arguments in call to i.GetImage
#41 44.98 have (string, "github.com/docker/docker/api/types/image".GetImageOpts)
#41 44.98 want (context.Context, string, "github.com/docker/docker/api/types/image".GetImageOpts)
#41 44.98 daemon/images/image_pull.go:67:33: not enough arguments in call to i.GetImage
#41 44.98 have (string, "github.com/docker/docker/api/types/image".GetImageOpts)
#41 44.98 want (context.Context, string, "github.com/docker/docker/api/types/image".GetImageOpts)
#41 44.98 daemon/images/image_pull.go:67:33: too many errors
#41 ERROR: process "/bin/sh -c hack/make.sh binary" did not complete successfully: exit code: 2
Contributor
Author
There was a problem hiding this comment.
yes sorry, this was just an initial experiment based on cherry-picking a single commit, shouldhave ben opened as Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
upstream rumpl#27