replace pkg/system Sequential funcs with moby/sys/sequential#44051
Merged
cpuguy83 merged 1 commit intomoby:masterfrom Aug 30, 2022
Merged
replace pkg/system Sequential funcs with moby/sys/sequential#44051cpuguy83 merged 1 commit intomoby:masterfrom
cpuguy83 merged 1 commit intomoby:masterfrom
Conversation
thaJeztah
added
status/2-code-review
process/cherry-pick
kind/refactor
This was referenced Aug 27, 2022
thaJeztah
force-pushed
the
migrate_sequential
branch
from
ca40049 to
0e29ade
Compare
thaJeztah
changed the title
thaJeztah
commented
Aug 29, 2022
| github.com/moby/swarmkit/v2 v2.0.0-20220721174824-48dd89375d0a | ||
| github.com/moby/sys/mount v0.3.3 | ||
| github.com/moby/sys/mountinfo v0.6.2 | ||
| github.com/moby/sys/sequential v0.0.0-20220829095930-b22ba8a69b30 |
Member
Author
There was a problem hiding this comment.
No release yet, but I'll do a release once review of all PR's is looking good, and will update to v0.5.0 (once released) in a follow-up.
Member
Author
|
Ah, dang, needs a rebase after #44052 was merged. Could've seen that one coming 😂 |
thaJeztah
force-pushed
the
migrate_sequential
branch
from
0e29ade to
07b1692
Compare
Member
Author
|
done 👍 |
thaJeztah
force-pushed
the
migrate_sequential
branch
from
07b1692 to
691f585
Compare
Migrating these functions to allow them being shared between moby, docker/cli, and containerd, and to allow using them without importing all of sys / system, which (in containerd) also depends on hcsshim and more. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
migrate_sequential
branch
from
691f585 to
509f19f
Compare
AkihiroSuda
approved these changes
Aug 30, 2022
Member
Author
|
@cpuguy83 this one LGTY as well? |
cpuguy83
approved these changes
Aug 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrating these functions to allow them being shared between moby, docker/cli,
and containerd, and to allow using them without importing all of sys / system,
which (in containerd) also depends on hcsshim and more.
- A picture of a cute animal (not mandatory but encouraged)